[
https://issues.apache.org/jira/browse/BEAM-7310?focusedWorklogId=376303&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376303
]
ASF GitHub Bot logged work on BEAM-7310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/20 15:41
Start Date: 23/Jan/20 15:41
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #10563: [BEAM-7310]
Add support of Confluent Schema Registry for KafkaIO
URL: https://github.com/apache/beam/pull/10563#issuecomment-577737210
@rangadi Thank you for feedback! I agree with your naming proposal despite
that afaik only one Avro Schema Registry exists (Confluent's one). In the same
time, to avoid a confusion with Beam schema we should probably name it
explicitly `withConfluentSchemaRegistry()`. Do you think we need to name other
new public methods in this way, like `getKeySchemaSubject()` and
`getValueSchemaSubject()` should be `getKeyConfluentSchemaSubject()` and
`getValueConfluentSchemaSubject()` ?
@rangadi @iemejia Also, now I'm thinking to reduce the number of new public
methods, introduced by this PR, and to add only
`withConfluentSchemaRegistry(ConfluentSchemaRegistryProvider)` where
`ConfluentSchemaRegistryProvider` will incorporate all required members
(registry URL, subjects, ClientFactoryFn) to use CSR in `KafkaIO`, like we do
for KinesisIO with `AWSClientsProvider`. Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 376303)
Time Spent: 8h 10m (was: 8h)
> Confluent Schema Registry support in KafkaIO
> --------------------------------------------
>
> Key: BEAM-7310
> URL: https://issues.apache.org/jira/browse/BEAM-7310
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kafka
> Affects Versions: 2.12.0
> Reporter: Yohei Shimomae
> Assignee: Alexey Romanenko
> Priority: Minor
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Confluent Schema Registry is useful when we manage Avro Schema but KafkaIO
> does not support Confluent Schema Registry as discussed here.
> https://stackoverflow.com/questions/56035121/unable-to-connect-from-dataflow-job-to-schema-registry-when-schema-registry-requ
> https://lists.apache.org/thread.html/7695fccddebd08733b80ae1e43b79b636b63cd5fe583a2bdeecda6c4@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
