[
https://issues.apache.org/jira/browse/BEAM-7310?focusedWorklogId=376348&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376348
]
ASF GitHub Bot logged work on BEAM-7310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/20 17:20
Start Date: 23/Jan/20 17:20
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #10563: [BEAM-7310] Add
support of Confluent Schema Registry for KafkaIO
URL: https://github.com/apache/beam/pull/10563#issuecomment-577781860
Thanks for changes code looks ok for me :+1:
About your proposals you have a valid point about Beam's schema in the
naming (hard to reconcile):
+1 for `withConfluentSchemaRegistry`
0 for getKeyConfluentSchemaSubject and getValueConfluentSchemaSubject
The idea of the new object to have only one new signature sounds GORGEOUS to
me please PLEASE !
Please tell me when can I take a look again, and thanks for your patience
during the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 376348)
Time Spent: 8h 20m (was: 8h 10m)
> Confluent Schema Registry support in KafkaIO
> --------------------------------------------
>
> Key: BEAM-7310
> URL: https://issues.apache.org/jira/browse/BEAM-7310
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kafka
> Affects Versions: 2.12.0
> Reporter: Yohei Shimomae
> Assignee: Alexey Romanenko
> Priority: Minor
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> Confluent Schema Registry is useful when we manage Avro Schema but KafkaIO
> does not support Confluent Schema Registry as discussed here.
> https://stackoverflow.com/questions/56035121/unable-to-connect-from-dataflow-job-to-schema-registry-when-schema-registry-requ
> https://lists.apache.org/thread.html/7695fccddebd08733b80ae1e43b79b636b63cd5fe583a2bdeecda6c4@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
