[
https://issues.apache.org/jira/browse/BEAM-9273?focusedWorklogId=384933&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384933
]
ASF GitHub Bot logged work on BEAM-9273:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/20 02:25
Start Date: 11/Feb/20 02:25
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #10816:
[BEAM-9273] Explicitly disable @RequiresTimeSortedInput on unsupported runners
URL: https://github.com/apache/beam/pull/10816#discussion_r377421456
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/BatchStatefulParDoOverrides.java
##########
@@ -176,7 +176,7 @@ private MultiOutputOverrideFactory(boolean isFnApi) {
public PCollection<OutputT> expand(PCollection<KV<K, InputT>> input) {
DoFn<KV<K, InputT>, OutputT> fn = originalParDo.getFn();
verifyFnIsStateful(fn);
- DataflowRunner.verifyStateSupported(fn);
+ DataflowRunner.verifyDoFnSupported(fn, false);
Review comment:
Passing a raw bool into a function call is not very readable. I suggest
splitting into `verifyDoFnSupportedForStreaming` and
`verifyDoFnSupportedForBatch`. These can each call the common code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 384933)
Time Spent: 2h 50m (was: 2h 40m)
> Explicitly fail pipeline with @RequiresTimeSortedInput with unsupported runner
> ------------------------------------------------------------------------------
>
> Key: BEAM-9273
> URL: https://issues.apache.org/jira/browse/BEAM-9273
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Fail pipeline with @RequiresTimeSortedInput annotation in pipeline
> translation time when being run with unsupported runner. Currently,
> unsupported runners are:
> - apex
> - portable flink
> - gearpump
> - dataflow
> - jet
> - samza
> - spark structured streaming
> These runners should reject the pipeline.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
