[
https://issues.apache.org/jira/browse/BEAM-9273?focusedWorklogId=384932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384932
]
ASF GitHub Bot logged work on BEAM-9273:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/20 02:25
Start Date: 11/Feb/20 02:25
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #10816:
[BEAM-9273] Explicitly disable @RequiresTimeSortedInput on unsupported runners
URL: https://github.com/apache/beam/pull/10816#discussion_r377421862
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##########
@@ -1224,10 +1225,10 @@ private static void translateFn(
Map<TupleTag<?>, Coder<?>> outputCoders,
DoFnSchemaInformation doFnSchemaInformation,
Map<String, PCollectionView<?>> sideInputMapping) {
- DoFnSignature signature = DoFnSignatures.getSignature(fn.getClass());
- if (signature.usesState() || signature.usesTimers()) {
- DataflowRunner.verifyStateSupported(fn);
+ boolean isStateful = DoFnFeatures.isStateful(fn);
Review comment:
This is a good example of `DoFnFeatures` being useful: since "stateful
ParDo" is really a totally separate primitive, it makes sense to just have a
single boolean indicating it. Eventually moving so the different primitives are
more clearly split with different URNs would be good.
(no action for you here - just a positive comment)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 384932)
Time Spent: 2h 40m (was: 2.5h)
> Explicitly fail pipeline with @RequiresTimeSortedInput with unsupported runner
> ------------------------------------------------------------------------------
>
> Key: BEAM-9273
> URL: https://issues.apache.org/jira/browse/BEAM-9273
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Fail pipeline with @RequiresTimeSortedInput annotation in pipeline
> translation time when being run with unsupported runner. Currently,
> unsupported runners are:
> - apex
> - portable flink
> - gearpump
> - dataflow
> - jet
> - samza
> - spark structured streaming
> These runners should reject the pipeline.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
