[
https://issues.apache.org/jira/browse/BEAM-9273?focusedWorklogId=386232&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386232
]
ASF GitHub Bot logged work on BEAM-9273:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Feb/20 21:04
Start Date: 12/Feb/20 21:04
Worklog Time Spent: 10m
Work Description: je-ik commented on pull request #10816: [BEAM-9273]
Explicitly disable @RequiresTimeSortedInput on unsupported runners
URL: https://github.com/apache/beam/pull/10816#discussion_r378511266
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/BatchStatefulParDoOverrides.java
##########
@@ -176,7 +176,7 @@ private MultiOutputOverrideFactory(boolean isFnApi) {
public PCollection<OutputT> expand(PCollection<KV<K, InputT>> input) {
DoFn<KV<K, InputT>, OutputT> fn = originalParDo.getFn();
verifyFnIsStateful(fn);
- DataflowRunner.verifyStateSupported(fn);
+ DataflowRunner.verifyDoFnSupported(fn, false);
Review comment:
I added both versions, although the second one
`verifyDoFnSupportedStreaming` is not used. I added that so that the methods
are not imbalanced. The streaming case is called from
`DataflowRunner.verifyDoFnSupported(fn,
context.getPipelineOptions().isStreaming())`, where it would be weird to do `if
(context..isStream()) verifyStreaming() else ...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 386232)
Time Spent: 4h 10m (was: 4h)
> Explicitly fail pipeline with @RequiresTimeSortedInput with unsupported runner
> ------------------------------------------------------------------------------
>
> Key: BEAM-9273
> URL: https://issues.apache.org/jira/browse/BEAM-9273
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Fail pipeline with @RequiresTimeSortedInput annotation in pipeline
> translation time when being run with unsupported runner. Currently,
> unsupported runners are:
> - apex
> - portable flink
> - gearpump
> - dataflow
> - jet
> - samza
> - spark structured streaming
> These runners should reject the pipeline.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
