[
https://issues.apache.org/jira/browse/BEAM-3545?focusedWorklogId=386338&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386338
]
ASF GitHub Bot logged work on BEAM-3545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Feb/20 01:19
Start Date: 13/Feb/20 01:19
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10777: [BEAM-3545]
Return metrics as MonitoringInfos
URL: https://github.com/apache/beam/pull/10777#discussion_r378604151
##########
File path: sdks/go/pkg/beam/core/runtime/exec/datasource.go
##########
@@ -37,11 +37,13 @@ type DataSource struct {
Coder *coder.Coder
Out Node
- source DataManager
- state StateReader
- index int64
- splitIdx int64
- start time.Time
+ source DataManager
+ state StateReader
+ // TODO(lostluck) 2020/02/06: refactor to support more general
PCollection metrics on nodes.
+ outputPID string // The index is the output count for the PCollection.
Review comment:
outputPID/PID isn't a great name for PCOllection ids since PID is used as
PTrasnformId elsewhere.
Consider fixing here and elsewhere. Also, this comment should really say
that this is the output pcollection id and not an implementation detail like
this is the "index" since thats an implementation detail elsewhere about the
mapping which this code shouldn't care about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 386338)
Time Spent: 15h 50m (was: 15h 40m)
> Fn API metrics in Go SDK harness
> --------------------------------
>
> Key: BEAM-3545
> URL: https://issues.apache.org/jira/browse/BEAM-3545
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kenneth Knowles
> Assignee: Robert Burke
> Priority: Major
> Labels: portability
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
