[
https://issues.apache.org/jira/browse/BEAM-3545?focusedWorklogId=389707&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389707
]
ASF GitHub Bot logged work on BEAM-3545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/20 00:40
Start Date: 20/Feb/20 00:40
Worklog Time Spent: 10m
Work Description: lostluck commented on issue #10906: [BEAM-3545] Fix
race condition w/plan metrics.
URL: https://github.com/apache/beam/pull/10906#issuecomment-588550039
It's more that Down shouldn't be called while Execute/Process is running.
It's part of the contract for Units (see exec/unit.go) that they aren't
required to be concurrency safe.
The metrics do mess up this formulation though, since they *must* be
accessible outside of the plan execution. I did consider instead simply having
the store created outside of the plan, which would mean the harness would need
to handle the asynchronous storage/access for it (probably as part of one of
the maps in harness). That would probably save a lock. What do you think?
There are several more changes coming here for PCollection and PTransform
metrics, and while I don't like churn, I'll be following up in another PR
anyway, so it can be cleaned up then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 389707)
Time Spent: 16h 50m (was: 16h 40m)
> Fn API metrics in Go SDK harness
> --------------------------------
>
> Key: BEAM-3545
> URL: https://issues.apache.org/jira/browse/BEAM-3545
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kenneth Knowles
> Assignee: Robert Burke
> Priority: Major
> Labels: portability
> Time Spent: 16h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
