[
https://issues.apache.org/jira/browse/BEAM-3545?focusedWorklogId=389728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389728
]
ASF GitHub Bot logged work on BEAM-3545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/20 01:01
Start Date: 20/Feb/20 01:01
Worklog Time Spent: 10m
Work Description: youngoli commented on issue #10906: [BEAM-3545] Fix
race condition w/plan metrics.
URL: https://github.com/apache/beam/pull/10906#issuecomment-588556050
That makes sense.
I do kinda like moving the metrics store outside of the plan and into the
harness/direct runner. It doesn't seem like the plan actually needs the store,
it's just being used as a container for the harness/direct runner to access and
pass it to monitoring. But it's such a small difference that I have no
objections to leaving it as-is. I was mainly concerned whether there was
another race condition, not so much about style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 389728)
Time Spent: 17h 10m (was: 17h)
> Fn API metrics in Go SDK harness
> --------------------------------
>
> Key: BEAM-3545
> URL: https://issues.apache.org/jira/browse/BEAM-3545
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kenneth Knowles
> Assignee: Robert Burke
> Priority: Major
> Labels: portability
> Time Spent: 17h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
