[
https://issues.apache.org/jira/browse/BEAM-9347?focusedWorklogId=392073&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392073
]
ASF GitHub Bot logged work on BEAM-9347:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/20 20:29
Start Date: 24/Feb/20 20:29
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #10919: [BEAM-9347]
Don't overwrite default runner harness for unified worker
URL: https://github.com/apache/beam/pull/10919#discussion_r383492636
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -916,6 +919,9 @@ def _use_unified_worker(pipeline_options):
debug_options = pipeline_options.view_as(DebugOptions)
use_unified_worker_flag = 'use_unified_worker'
+ if debug_options.lookup_experiment(use_unified_worker_flag):
Review comment:
We can move 925-926 to dataflow_runner.py but then i feel the logic to
determine unified_worker usage will be more staggered.
I think it will be better to keep the interpretation of `use_unified_worker`
and `use_runner_v2` at a single place.
For now, we support both flag but I think we will transition to
`use_runner_v2` over time (not sure by when).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 392073)
Time Spent: 1h 40m (was: 1.5h)
> Remove default image for Unified Worker
> ---------------------------------------
>
> Key: BEAM-9347
> URL: https://issues.apache.org/jira/browse/BEAM-9347
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The runner will choose the Runner Harness image for UW so we don't need to
> overwrite the image in default behavior.
> Also, this will help us distinguish between user requested overwrites for the
> default overwrites(which is not used).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
