[
https://issues.apache.org/jira/browse/BEAM-9347?focusedWorklogId=392092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392092
]
ASF GitHub Bot logged work on BEAM-9347:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/20 21:16
Start Date: 24/Feb/20 21:16
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #10919: [BEAM-9347]
Don't overwrite default runner harness for unified worker
URL: https://github.com/apache/beam/pull/10919#discussion_r383516953
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -186,8 +186,13 @@ def __init__(self, packages, options,
environment_version, pipeline_url):
if job_type.startswith('FNAPI_'):
self.debug_options = self.debug_options or DebugOptions()
self.debug_options.experiments = self.debug_options.experiments or []
- if not self.debug_options.lookup_experiment(
- 'runner_harness_container_image'):
+ if self.debug_options.lookup_experiment(
Review comment:
Few thoughts here
1. I think we cannot instantiate `DebugOptions()` in `self.debug_options =
self.debug_options or DebugOptions()`. We should create a view of existing
`options`. All views of pipeline options should be views of the same
underlying object, and I think that line will break it. Do you know why we
added it?
2. For the purpose of this PR it should be sufficient to pass `options` into
`_use_unified_worker()` in line 190.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 392092)
Time Spent: 2h (was: 1h 50m)
> Remove default image for Unified Worker
> ---------------------------------------
>
> Key: BEAM-9347
> URL: https://issues.apache.org/jira/browse/BEAM-9347
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The runner will choose the Runner Harness image for UW so we don't need to
> overwrite the image in default behavior.
> Also, this will help us distinguish between user requested overwrites for the
> default overwrites(which is not used).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
