[
https://issues.apache.org/jira/browse/BEAM-9347?focusedWorklogId=392091&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392091
]
ASF GitHub Bot logged work on BEAM-9347:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/20 21:16
Start Date: 24/Feb/20 21:16
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #10919: [BEAM-9347]
Don't overwrite default runner harness for unified worker
URL: https://github.com/apache/beam/pull/10919#discussion_r383516522
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -916,6 +919,9 @@ def _use_unified_worker(pipeline_options):
debug_options = pipeline_options.view_as(DebugOptions)
use_unified_worker_flag = 'use_unified_worker'
+ if debug_options.lookup_experiment(use_unified_worker_flag):
Review comment:
I think that it would be cleaner to not modify experiments in
`_use_unified_worker`, since the name of this method does not suggest that it
modifies the state, and it would also be easier to follow the logic. Also, if
Dataflow runner relies on the fact that "use_runner_v2" experiment is set, it
might be better to set it explicitly at some point, instead of relying on the
fact that "_use_unified_worker" will be called. Leaving this up to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 392091)
Time Spent: 2h (was: 1h 50m)
> Remove default image for Unified Worker
> ---------------------------------------
>
> Key: BEAM-9347
> URL: https://issues.apache.org/jira/browse/BEAM-9347
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The runner will choose the Runner Harness image for UW so we don't need to
> overwrite the image in default behavior.
> Also, this will help us distinguish between user requested overwrites for the
> default overwrites(which is not used).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
