[
https://issues.apache.org/jira/browse/BEAM-9382?focusedWorklogId=396597&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-396597
]
ASF GitHub Bot logged work on BEAM-9382:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/20 02:53
Start Date: 03/Mar/20 02:53
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #10988: [BEAM-9382]
Clean up of TestStreamTranscriptTests.
URL: https://github.com/apache/beam/pull/10988#issuecomment-593740435
Since we are doing drive by comments, perhaps a clear comment describing
exactly what the test is trying to verify would allow us to be sure to have all
the necessary verifications but no extraneous info.
Also I assume you mean the Python direct runner (each language has a direct
runner for that language) since I think the Java direct runner does support
pane info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 396597)
Time Spent: 50m (was: 40m)
> TestStreamTranscriptTest relies on non-deterministic behavior
> -------------------------------------------------------------
>
> Key: BEAM-9382
> URL: https://issues.apache.org/jira/browse/BEAM-9382
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Andrew Crites
> Assignee: Andrew Crites
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The test discarding_early_fixed uses an early trigger Count(2) and then
> inserts 3 elements, assuming all 3 will get emitted in the early pane.
> However, runners do not have to follow this behavior. Instead, they could
> emit the first two elements seen and then buffer the third until something
> else comes in. We should change this test to only insert 2 elements so that
> all runners will behave the same.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
