[
https://issues.apache.org/jira/browse/BEAM-9382?focusedWorklogId=396616&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-396616
]
ASF GitHub Bot logged work on BEAM-9382:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/20 03:52
Start Date: 03/Mar/20 03:52
Worklog Time Spent: 10m
Work Description: acrites commented on issue #10988: [BEAM-9382] Clean up
of TestStreamTranscriptTests.
URL: https://github.com/apache/beam/pull/10988#issuecomment-593753721
Along the lines of what Kenn is saying, I had originally thought that these
tests weren't really testing whether or not PaneInfo.final gets set correctly
in the various triggering strategies, but more so that it was outputting the
correct elements. Maybe we want to test all aspects in a single test though.
I'm fine with sickbaying the tests for Python direct runner if you're ok
with having a large number of tests inactive until we getting around to fixing
direct runner. Maybe that'll motivate us to get it fixed faster...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 396616)
Time Spent: 1h (was: 50m)
> TestStreamTranscriptTest relies on non-deterministic behavior
> -------------------------------------------------------------
>
> Key: BEAM-9382
> URL: https://issues.apache.org/jira/browse/BEAM-9382
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Andrew Crites
> Assignee: Andrew Crites
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The test discarding_early_fixed uses an early trigger Count(2) and then
> inserts 3 elements, assuming all 3 will get emitted in the early pane.
> However, runners do not have to follow this behavior. Instead, they could
> emit the first two elements seen and then buffer the third until something
> else comes in. We should change this test to only insert 2 elements so that
> all runners will behave the same.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
