[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=418911&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-418911
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/20 21:33
Start Date: 08/Apr/20 21:33
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11314: [BEAM-9562]
Send Timers over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405824290
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -1088,6 +1142,30 @@ def create_operation(self,
transform_proto.spec.payload, parameter_type)
return creator(self, transform_id, transform_proto, payload, consumers)
+ def get_timer_coders(self):
+ timer_coder = {}
+ for transform_id, transform_proto in self.descriptor.transforms.items():
Review comment:
I see us doing this loop three times now. Perhaps it would be more useful to
do the loop once to set everything up, creating a single dictionary
(transform_id, timer_family_id) -> (all info about that timer we need to
dispatch them).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 418911)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 14h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
