[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=418955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-418955
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/20 22:53
Start Date: 08/Apr/20 22:53
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #11314:
[BEAM-9562] Send Timers over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405855696
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/BatchDataflowWorker.java
##########
@@ -238,9 +238,14 @@ protected BatchDataflowWorker(
sdkFusedStage =
pipeline == null
? RegisterNodeFunction.withoutPipeline(
- idGenerator,
sdkHarnessRegistry.beamFnStateApiServiceDescriptor())
+ idGenerator,
+ sdkHarnessRegistry.beamFnStateApiServiceDescriptor(),
+ sdkHarnessRegistry.beamFnDataApiServiceDescriptor())
Review comment:
Isn't the timer API service descriptor different from the data API service
descriptor? Does that need to be plumbed through SdkHarnessRegistry and used
here instead of the data API descriptor? (same question below and in streaming
worker)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 418955)
Time Spent: 15h (was: 14h 50m)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 15h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
