[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=418967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-418967
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/20 23:24
Start Date: 08/Apr/20 23:24
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11314: [BEAM-9562]
Send Timers over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405870539
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ParDoTranslation.java
##########
@@ -257,6 +230,19 @@ public static ParDoPayload translateParDo(
restrictionCoderId = "";
}
+ Coder<BoundedWindow> windowCoder =
+ (Coder<BoundedWindow>)
mainInput.getWindowingStrategy().getWindowFn().windowCoder();
+ Coder<?> keyCoder;
+ if (signature.usesState() || signature.usesTimers()) {
+ checkArgument(
+ mainInput.getCoder() instanceof KvCoder,
+ "DoFn's that use state or timers must have an input PCollection with
a KvCoder but received %s",
+ mainInput.getCoder());
Review comment:
It was being covered by validation in DoFnSignatures but it is being
repeated here for defense in depth reasons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 418967)
Time Spent: 15h 10m (was: 15h)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
