[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=419203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419203
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 07:21
Start Date: 09/Apr/20 07:21
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11314: [BEAM-9562]
Send Timers over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405999089
##########
File path: sdks/python/apache_beam/runners/worker/data_plane.py
##########
@@ -354,15 +410,15 @@ def input_elements(self,
Args:
instruction_id(str): instruction_id for which data is read
- expected_transforms(collection): expected transforms
+ expected_inputs(collection): expected inputs, include both data and
timer.
"""
received = self._receiving_queue(instruction_id)
- done_transforms = set() # type: Set[str]
+ done_inputs = set() # type: Set[str]
Review comment:
update type hint
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 419203)
Time Spent: 17h 40m (was: 17.5h)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 17h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
