[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=419193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419193
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 07:21
Start Date: 09/Apr/20 07:21
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11314: [BEAM-9562]
Send Timers over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405990412
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -745,6 +746,24 @@ def __init__(self,
self.process_bundle_descriptor = process_bundle_descriptor
self.state_handler = state_handler
self.data_channel_factory = data_channel_factory
+
+ # There is no guarantee that the runner only set
+ # timer_api_service_descriptor when having timers. So this field cannot be
+ # used as an indicator of timers.
+ if self.process_bundle_descriptor.timer_api_service_descriptor:
+ self.timer_data_channel = (
+ data_channel_factory.create_data_channel_from_url(
+ self.process_bundle_descriptor.timer_api_service_descriptor.url))
+ else:
+ self.timer_data_channel = None
+
+ # A mapping of
+ # {(transform_id, timer_family_id):
+ # {"timer_coder_impl": coder, "output_stream": stream}}
+ # The mapping keeps empty when there is no timer_family_specs in the
Review comment:
Nit: The mapping stays (or is) empty...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 419193)
Time Spent: 17h 10m (was: 17h)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 17h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
