[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=419198&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419198
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 07:21
Start Date: 09/Apr/20 07:21
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11314: [BEAM-9562]
Send Timers over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405998009
##########
File path: sdks/python/apache_beam/runners/worker/data_plane.py
##########
@@ -274,20 +301,47 @@ def inverse(self):
return self._inverse
def input_elements(self,
- instruction_id, # type: str
- unused_expected_transforms=None, # type:
Optional[Collection[str]]
- abort_callback=None # type: Optional[Callable[[], bool]]
- ):
- # type: (...) -> Iterator[beam_fn_api_pb2.Elements.Data]
Review comment:
It'd be good to not lose the typing information. You can make an alias at
the top of the file `DataOrTimers = Union[beam_fn_api_pb2.Elements.Data,
beam_fn_api_pb2.Elements.Timer]` to cut down on verbosity, here and elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 419198)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 17h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
