[jira] [Work logged] (BEAM-9815) beam_PostCommit_Go perma red due to failing to start container

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/BEAM-9815?focusedWorklogId=427705&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427705
 ]

ASF GitHub Bot logged work on BEAM-9815:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Apr/20 16:28
            Start Date: 27/Apr/20 16:28
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on a change in pull request #11524:
URL: https://github.com/apache/beam/pull/11524#discussion_r415960127



##########
File path: sdks/go/test/run_integration_tests.sh
##########
@@ -102,9 +102,8 @@ case $key in
 esac
 done
 
-if [[ "$RUNNER" != "universal" ]]; then
-  PUSH_CONTAINER_TO_GCR='yes'
-else
+PUSH_CONTAINER_TO_GCR='yes'

Review comment:
       Isn't it better to avoid double assignment? 

##########
File path: sdks/go/test/run_integration_tests.sh
##########
@@ -118,7 +117,7 @@ test -d sdks/go/test
 command -v docker
 docker -v
 
-if [[ PUSH_CONTAINER_TO_GCR == 'yes' ]]; then
+if [ "$PUSH_CONTAINER_TO_GCR" = "yes" ]; then

Review comment:
       I used double brackets because that's what was used in the rest of the 
file. We should be consistent. 

##########
File path: sdks/go/test/run_integration_tests.sh
##########
@@ -148,7 +147,7 @@ if [[ PUSH_CONTAINER_TO_GCR == 'yes' ]]; then
 
   # Push the container
   gcloud docker -- push $CONTAINER
-else
+else 

Review comment:
       extra space

##########
File path: sdks/go/container/boot.go
##########
@@ -104,7 +104,7 @@ func main() {
 
        switch len(artifacts) {
        case 0:
-               log.Fatal("No artifacts staged")
+               log.Printf("No artifacts staged. Attempting to run default 
\"worker\".")

Review comment:
       Shouldn't this be fatal? There isn't a "default" worker. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 427705)
    Time Spent: 1h 20m  (was: 1h 10m)

> beam_PostCommit_Go perma red due to failing to start container
> --------------------------------------------------------------
>
>                 Key: BEAM-9815
>                 URL: https://issues.apache.org/jira/browse/BEAM-9815
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go, test-failures
>            Reporter: Chamikara Madhusanka Jayalath
>            Assignee: Robert Bradshaw
>            Priority: Critical
>              Labels: currently-failing
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> For example,
> [https://builds.apache.org/job/beam_PostCommit_Go/6847/]
> [https://pantheon.corp.google.com/logs/viewer?project=apache-beam-testing&folder&organizationId&minLogLevel=500&expandAll=false&timestamp=2020-04-24T15:09:13.455000000Z&customFacets=&limitCustomFacetWidth=true&interval=NO_LIMIT&resource=dataflow_step%2Fjob_id%2F2020-04-24_05_03_49-5495819388067192698&scrollTimestamp=2020-04-24T13:03:38.313084000Z]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)