[jira] [Work logged] (BEAM-9815) beam_PostCommit_Go perma red due to failing to start container

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/BEAM-9815?focusedWorklogId=427727&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427727
 ]

ASF GitHub Bot logged work on BEAM-9815:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Apr/20 17:18
            Start Date: 27/Apr/20 17:18
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on a change in pull request #11524:
URL: https://github.com/apache/beam/pull/11524#discussion_r416000017



##########
File path: sdks/go/test/run_integration_tests.sh
##########
@@ -102,9 +102,8 @@ case $key in
 esac
 done
 
-if [[ "$RUNNER" != "universal" ]]; then
-  PUSH_CONTAINER_TO_GCR='yes'
-else
+PUSH_CONTAINER_TO_GCR='yes'

Review comment:
       I'd guess that is because in Go one wants to use the declare-and-define 
syntax, which wouldn't work inside the if clause. The convention is opposite in 
Java/Python (where more value is placed on immutability). As for bash, well, I 
doubt there's any consistency around there... This is fine if you prefer. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 427727)
    Time Spent: 1h 50m  (was: 1h 40m)

> beam_PostCommit_Go perma red due to failing to start container
> --------------------------------------------------------------
>
>                 Key: BEAM-9815
>                 URL: https://issues.apache.org/jira/browse/BEAM-9815
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go, test-failures
>            Reporter: Chamikara Madhusanka Jayalath
>            Assignee: Robert Bradshaw
>            Priority: Critical
>              Labels: currently-failing
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> For example,
> [https://builds.apache.org/job/beam_PostCommit_Go/6847/]
> [https://pantheon.corp.google.com/logs/viewer?project=apache-beam-testing&folder&organizationId&minLogLevel=500&expandAll=false&timestamp=2020-04-24T15:09:13.455000000Z&customFacets=&limitCustomFacetWidth=true&interval=NO_LIMIT&resource=dataflow_step%2Fjob_id%2F2020-04-24_05_03_49-5495819388067192698&scrollTimestamp=2020-04-24T13:03:38.313084000Z]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)