[jira] [Work logged] (BEAM-9815) beam_PostCommit_Go perma red due to failing to start container

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/BEAM-9815?focusedWorklogId=427710&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427710
 ]

ASF GitHub Bot logged work on BEAM-9815:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Apr/20 16:38
            Start Date: 27/Apr/20 16:38
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on a change in pull request #11524:
URL: https://github.com/apache/beam/pull/11524#discussion_r415970418



##########
File path: sdks/go/test/run_integration_tests.sh
##########
@@ -102,9 +102,8 @@ case $key in
 esac
 done
 
-if [[ "$RUNNER" != "universal" ]]; then
-  PUSH_CONTAINER_TO_GCR='yes'
-else
+PUSH_CONTAINER_TO_GCR='yes'

Review comment:
       Not sure, the root issue seemed to be how the comparison operated 
though, rather than the assignement. I'll see if I can get the comparison to 
work properly but otherwise revert this.
   
   Tangent: This is the "preferred" way of handling variable cases like this 
for Go, where the common case for the variable is used by default, and 
overridden by the special case. (Obviously if calculating the default value is 
expensive, and the special case is cheap, the calculus changes, since compute 
has cost.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 427710)
    Time Spent: 1h 40m  (was: 1.5h)

> beam_PostCommit_Go perma red due to failing to start container
> --------------------------------------------------------------
>
>                 Key: BEAM-9815
>                 URL: https://issues.apache.org/jira/browse/BEAM-9815
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go, test-failures
>            Reporter: Chamikara Madhusanka Jayalath
>            Assignee: Robert Bradshaw
>            Priority: Critical
>              Labels: currently-failing
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> For example,
> [https://builds.apache.org/job/beam_PostCommit_Go/6847/]
> [https://pantheon.corp.google.com/logs/viewer?project=apache-beam-testing&folder&organizationId&minLogLevel=500&expandAll=false&timestamp=2020-04-24T15:09:13.455000000Z&customFacets=&limitCustomFacetWidth=true&interval=NO_LIMIT&resource=dataflow_step%2Fjob_id%2F2020-04-24_05_03_49-5495819388067192698&scrollTimestamp=2020-04-24T13:03:38.313084000Z]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)