[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=428332&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428332
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/20 19:08
Start Date: 28/Apr/20 19:08
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416855737
##########
File path: sdks/java/container/build.gradle
##########
@@ -101,16 +84,44 @@ docker {
project.rootProject["docker-tag"] : project.sdk_version)
dockerfile project.file("./${dockerfileName}")
files "./build/"
+ buildArgs(['pull_licenses':
!project.rootProject.hasProperty(["no-licenses"])])
Review comment:
Sounds good. Sorry if this was covered in the discussion that I didn't
read, but why would we want to check urls but not pull? Feel free to point me
to the discussion.
Naming suggestion:
licenses-in-docker-images=add
licenses-in-docker-images=skip
licenses-in-docker-images=check_urls
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 428332)
Time Spent: 24h 20m (was: 24h 10m)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 24h 20m
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
