[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=428426&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428426
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/20 23:05
Start Date: 28/Apr/20 23:05
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on a change in pull request
#11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416975896
##########
File path: sdks/java/container/build.gradle
##########
@@ -101,16 +84,44 @@ docker {
project.rootProject["docker-tag"] : project.sdk_version)
dockerfile project.file("./${dockerfileName}")
files "./build/"
+ buildArgs(['pull_licenses':
!project.rootProject.hasProperty(["no-licenses"])])
Review comment:
The purpose of checking urls was to make sure files can be pulled from
the urls when create images. If we set it to skip, no url checking process
happened for the PRs and we may see many license issues when we create release
images. Then release managers need to fix the issues. If we add the checking
urls for each PR, contributors should fix the issues if any and will not have
to fix them during release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 428426)
Time Spent: 25h (was: 24h 50m)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 25h
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
