[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=428338&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428338
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/20 19:40
Start Date: 28/Apr/20 19:40
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on a change in pull request
#11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416874101
##########
File path: sdks/java/container/build.gradle
##########
@@ -101,16 +84,44 @@ docker {
project.rootProject["docker-tag"] : project.sdk_version)
dockerfile project.file("./${dockerfileName}")
files "./build/"
+ buildArgs(['pull_licenses':
!project.rootProject.hasProperty(["no-licenses"])])
Review comment:
In short, users want to create a lightweight images, without adding
licenses.
Lightweight images are welcomed for Jenkins test as well, it reduces image
size by 85MB for Java image. More discussion can be found at
[here](https://lists.apache.org/thread.html/rff9f05e08de6adf7c39c0f4c59f97ae1a2f3602768480fe9e31e0428%40%3Cdev.beam.apache.org%3E)
Naming suggestion sounds good to me, thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 428338)
Time Spent: 24.5h (was: 24h 20m)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 24.5h
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
