[
https://issues.apache.org/jira/browse/BEAM-8742?focusedWorklogId=431114&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431114
]
ASF GitHub Bot logged work on BEAM-8742:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/20 09:20
Start Date: 06/May/20 09:20
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #11558:
URL: https://github.com/apache/beam/pull/11558#discussion_r420653268
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkDebugPipelineOptions.java
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.flink;
+
+import org.apache.beam.sdk.options.Default;
+import org.apache.beam.sdk.options.Description;
+import org.apache.beam.sdk.options.PipelineOptions;
+
+/** Debug options which shouldn't normally be used. */
+public interface FlinkDebugPipelineOptions extends PipelineOptions {
+
+ @Description(
+ "If not null, reports the checkpoint duration of each ParDo stage in the
provided metric namespace.")
+ String getReportCheckpointDuration();
+
+ void setReportCheckpointDuration(String metricNamespace);
+
+ @Description(
+ "Shuts down sources which have been idle for the configured time of
milliseconds. Once a source has been "
+ + "shut down, chekpointing is not possible anymore. Shutting down
the sources eventually leads to pipeline "
+ + "shutdown once all input has been processed.")
+ @Default.Long(0)
+ Long getShutdownSourcesAfterIdleMs();
Review comment:
That's a good suggestion. I think we can consolidate the two. The
drawback is that we would break the existing parameter but if we also change
the default that wouldn't be a problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 431114)
Time Spent: 12h 50m (was: 12h 40m)
> Add stateful processing to ParDo load test
> ------------------------------------------
>
> Key: BEAM-8742
> URL: https://issues.apache.org/jira/browse/BEAM-8742
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> So far, the ParDo load test is not stateful. We should add a basic counter to
> test the stateful processing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
