[ 
https://issues.apache.org/jira/browse/BEAM-8742?focusedWorklogId=431122&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431122
 ]

ASF GitHub Bot logged work on BEAM-8742:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/May/20 09:24
            Start Date: 06/May/20 09:24
    Worklog Time Spent: 10m 
      Work Description: mxm commented on a change in pull request #11558:
URL: https://github.com/apache/beam/pull/11558#discussion_r420655324



##########
File path: 
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -455,6 +461,18 @@ public void open() throws Exception {
     if (!options.getDisableMetrics()) {
       flinkMetricContainer = new FlinkMetricContainer(getRuntimeContext());
       doFnRunner = new DoFnRunnerWithMetricsUpdate<>(stepName, doFnRunner, 
flinkMetricContainer);
+      String checkpointMetricNamespace =

Review comment:
       I thought about that. The checkpointing metrics are kept at the 
JobManager. They are not accessible by the operator. So in order not to change 
the logic of the load tests which relies on the metrics accumulated during the 
job, returned in the PipelineResult, I opted to go this route. 
   
   I think we may have to change the Beam service to allow querying job metrics 
during job runtime. At the moment, we can only retrieve them at the end of the 
job.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 431122)
    Time Spent: 13h 10m  (was: 13h)

> Add stateful processing to ParDo load test
> ------------------------------------------
>
>                 Key: BEAM-8742
>                 URL: https://issues.apache.org/jira/browse/BEAM-8742
>             Project: Beam
>          Issue Type: Sub-task
>          Components: testing
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Major
>          Time Spent: 13h 10m
>  Remaining Estimate: 0h
>
> So far, the ParDo load test is not stateful. We should add a basic counter to 
> test the stateful processing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to