[ 
https://issues.apache.org/jira/browse/BEAM-8742?focusedWorklogId=431299&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431299
 ]

ASF GitHub Bot logged work on BEAM-8742:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/May/20 16:38
            Start Date: 06/May/20 16:38
    Worklog Time Spent: 10m 
      Work Description: mxm commented on a change in pull request #11558:
URL: https://github.com/apache/beam/pull/11558#discussion_r420932855



##########
File path: 
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -455,6 +461,18 @@ public void open() throws Exception {
     if (!options.getDisableMetrics()) {
       flinkMetricContainer = new FlinkMetricContainer(getRuntimeContext());
       doFnRunner = new DoFnRunnerWithMetricsUpdate<>(stepName, doFnRunner, 
flinkMetricContainer);
+      String checkpointMetricNamespace =

Review comment:
       Yes, I agree that we want this to be more generic. I didn't want to 
mention the Flink metric reporter but I think that would introduce another 
level of complexity. Not sure if that is the right tool for the job. I'd rather 
query metrics through the job server and the rest api.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 431299)
    Time Spent: 14h 20m  (was: 14h 10m)

> Add stateful processing to ParDo load test
> ------------------------------------------
>
>                 Key: BEAM-8742
>                 URL: https://issues.apache.org/jira/browse/BEAM-8742
>             Project: Beam
>          Issue Type: Sub-task
>          Components: testing
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Major
>          Time Spent: 14h 20m
>  Remaining Estimate: 0h
>
> So far, the ParDo load test is not stateful. We should add a basic counter to 
> test the stateful processing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to