[
https://issues.apache.org/jira/browse/BEAM-4766?focusedWorklogId=440339&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440339
]
ASF GitHub Bot logged work on BEAM-4766:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/20 17:29
Start Date: 02/Jun/20 17:29
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11891:
URL: https://github.com/apache/beam/pull/11891#issuecomment-637696878
Linkage checker results:
```
beam-linkage-check.sh "beam-sdks-java-core"
remote: Enumerating objects: 8, done.
remote: Counting objects: 100% (8/8), done.
remote: Compressing objects: 100% (7/7), done.
remote: Total 8 (delta 0), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (8/8), 3.48 KiB | 890.00 KiB/s, done.
From https://github.com/apache/beam
fcb40cfa48..9c16b898f0 master -> origin/master
Previous HEAD position was e0def937b1 fixup! Address PR comments
HEAD is now at 9c16b898f0 Merge pull request #11890 from
kennknowles/jira-priorities
Tue 02 Jun 2020 10:21:17 AM PDT: Installing artifacts of master(9c16b898) to
Maven local repository.
Tue 02 Jun 2020 10:25:01 AM PDT: Running linkage check (baseline) for
beam-sdks-java-core in master
Tue 02 Jun 2020 10:25:01 AM PDT: to create a baseline (existing errors
before change) build/linkagecheck/baseline-beam-sdks-java-core.xml
Configuration on demand is an incubating feature.
> Task :runners:apex:buildDependencyTree
See the report at:
file:///usr/local/google/home/lcwik/git/beam/runners/apex/build/classes/java/main/org/apache/beam/runners/apex/dependency-tree
> Task :checkJavaLinkage
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
details.
Wrote the linkage errors as exclusion file:
build/linkagecheck/baseline-beam-sdks-java-core.xml
NOTE: This task published artifacts into your local Maven repository. You
may want to remove them manually.
Deprecated Gradle features were used in this build, making it incompatible
with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See
https://docs.gradle.org/5.2.1/userguide/command_line_interface.html#sec:command_line_warnings
BUILD SUCCESSFUL in 20s
968 actionable tasks: 172 executed, 796 up-to-date
Tue 02 Jun 2020 10:25:22 AM PDT: Installing artifacts of HEAD(e0def937) to
Maven local repository.
Tue 02 Jun 2020 10:25:41 AM PDT: Running linkage check (validate) for
beam-sdks-java-core in HEAD
Tue 02 Jun 2020 10:25:41 AM PDT: using baseline
build/linkagecheck/baseline-beam-sdks-java-core.xml
Configuration on demand is an incubating feature.
> Task :runners:apex:buildDependencyTree
See the report at:
file:///usr/local/google/home/lcwik/git/beam/runners/apex/build/classes/java/main/org/apache/beam/runners/apex/dependency-tree
> Task :checkJavaLinkage
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
details.
NOTE: This task published artifacts into your local Maven repository. You
may want to remove them manually.
Deprecated Gradle features were used in this build, making it incompatible
with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See
https://docs.gradle.org/5.2.1/userguide/command_line_interface.html#sec:command_line_warnings
BUILD SUCCESSFUL in 18s
968 actionable tasks: 172 executed, 796 up-to-date
Tue 02 Jun 2020 10:26:00 AM PDT: Done: 0
No new linkage errors
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 440339)
Time Spent: 1h 40m (was: 1.5h)
> Use vendored version of protobuf in sdks/java/core or replace usage of
> ByteString with something else
> -----------------------------------------------------------------------------------------------------
>
> Key: BEAM-4766
> URL: https://issues.apache.org/jira/browse/BEAM-4766
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Luke Cwik
> Priority: P2
> Labels: portability, stale-P2
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The sdk/java/core library will bring in the pipeline model proto to be able
> to perform Pipeline > proto translation within the SDK instead of it being
> hidden away in runners core and similar libraries so it makes a lot of sense
> to just migrate the implementation to use vendored protobuf.
>
> This is currently used in ByteKey and TextSource.
>
> An alternative would be to re-implement the logic to not use ByteStrings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
