[
https://issues.apache.org/jira/browse/BEAM-4766?focusedWorklogId=440634&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440634
]
ASF GitHub Bot logged work on BEAM-4766:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jun/20 07:36
Start Date: 03/Jun/20 07:36
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #11891:
URL: https://github.com/apache/beam/pull/11891#issuecomment-638017998
I expected that vendored-grpc could be coming via some transitive dependency
but it wasn't
https://repo1.maven.org/maven2/org/apache/beam/beam-sdks-java-core/2.21.0/beam-sdks-java-core-2.21.0.pom
Maybe we should revert this, the only positive outcome I can see of this now
is if at some moment `sdks/java/core` wants to act explictly on gRPC services
which I doubt save for the `External` transform but this transform can easily
be an extension to avoid adding the 20M in core.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 440634)
Time Spent: 2h 10m (was: 2h)
> Use vendored version of protobuf in sdks/java/core or replace usage of
> ByteString with something else
> -----------------------------------------------------------------------------------------------------
>
> Key: BEAM-4766
> URL: https://issues.apache.org/jira/browse/BEAM-4766
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Labels: portability, stale-P2
> Fix For: 2.23.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The sdk/java/core library will bring in the pipeline model proto to be able
> to perform Pipeline > proto translation within the SDK instead of it being
> hidden away in runners core and similar libraries so it makes a lot of sense
> to just migrate the implementation to use vendored protobuf.
>
> This is currently used in ByteKey and TextSource.
>
> An alternative would be to re-implement the logic to not use ByteStrings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
