sijie commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140032462
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
##########
@@ -1320,7 +1327,7 @@ public void close() throws InterruptedException,
BKException {
}
}
- private static class SyncCreateCallback implements CreateCallback {
+ static class SyncCreateCallback implements CreateCallback {
Review comment:
so if SyncxxxxCallback will be used across multiple classes, it would be to
move them to a util class. This util class is for converting the xxxCallbacks
and CompletableFutures. And add test cases for it.
SyncCallbackUtils is a good place to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
