sijie commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140038330
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java
##########
@@ -200,4 +214,181 @@ private void createComplete(int rc, LedgerHandle lh) {
cb.createComplete(rc, lh, ctx);
}
+ // Builder interface methods
+
+ private static final byte[] EMPTY_PASSWORD = new byte[0];
Review comment:
can you add an issue and leave a comment, to move the builder logic out of
op logic?
I understand we did this is to avoid producing new objects for each
operation. we can use netty recycler (object pooling) to achieve that, while
still have a clean separation between builder and op. so it is easier to extend
and maintain in future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
