sijie commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140033105
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
##########
@@ -1415,4 +1422,23 @@ static EventLoopGroup getDefaultEventLoopGroup() {
return new NioEventLoopGroup(numThreads, threadFactory);
}
}
+
+ private static final byte[] EMPTY_PASSWORD = new byte[0];
+
+ @Override
+ public CreateBuilder createLedgerOp() {
+ return new LedgerCreateOp(this);
+ }
+
+ @Override
+ public OpenBuilder openLedgerOp() {
+ return new LedgerOpenOp(this, -1, DigestType.CRC32, EMPTY_PASSWORD,
null, null);
Review comment:
I am wondering why can't you use `new LedgerOpenOp(this)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
