sijie commented on a change in pull request #510: Issue-605 BP-15 New CreateLedger API URL: https://github.com/apache/bookkeeper/pull/510#discussion_r143033798
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCallbackUtils.java ########## @@ -0,0 +1,278 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.bookkeeper.client; + +import com.google.common.collect.Iterators; +import java.util.Enumeration; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ExecutionException; +import static org.apache.bookkeeper.client.LedgerHandle.LOG; +import org.apache.bookkeeper.client.api.Handle; +import org.apache.bookkeeper.client.api.ReadHandle; + +/** + * Utility for callbacks + * + */ +class SyncCallbackUtils { + + /** + * Wait for a result. This is convenience method to implement callbacks + * + * @param <T> + * @param future + * @return + * @throws InterruptedException + * @throws BKException + */ + public static <T> T waitForResult(CompletableFuture<T> future) throws InterruptedException, BKException { + try { + return future.get(); + } catch (ExecutionException err) { + if (err.getCause() instanceof BKException) { + throw (BKException) err.getCause(); + } else { + BKException unexpectedConditionException + = BKException.create(BKException.Code.UnexpectedConditionException); + unexpectedConditionException.initCause(err.getCause()); + throw unexpectedConditionException; + } + + } + } + + /** + * Handle the Response Code and transform it to a BKException + * + * @param <T> + * @param rc + * @param result + * @param future + */ + public static <T> void finish(int rc, T result, CompletableFuture<T> future) { + if (rc != BKException.Code.OK) { + future.completeExceptionally(BKException.create(rc).fillInStackTrace()); + } else { + future.complete(result); + } + } + + static class SyncCreateCallback implements AsyncCallback.CreateCallback { + + private final CompletableFuture future; + + public SyncCreateCallback(CompletableFuture future) { + this.future = future; + } + + /** + * Create callback implementation for synchronous create call. + * + * @param rc return code + * @param lh ledger handle object + * @param ctx optional control object + */ + @Override + @SuppressWarnings(value = "unchecked") + public void createComplete(int rc, LedgerHandle lh, Object ctx) { + SyncCallbackUtils.finish(rc, lh, future); + } + + } + + static class SyncOpenCallback<T> implements AsyncCallback.OpenCallback { + + private final CompletableFuture future; + + public SyncOpenCallback(CompletableFuture future) { + this.future = future; + } + + /** + * Callback method for synchronous open operation + * + * @param rc + * return code + * @param lh + * ledger handle + * @param ctx + * optional control object + */ + @Override + @SuppressWarnings("unchecked") + public void openComplete(int rc, LedgerHandle lh, Object ctx) { + SyncCallbackUtils.finish(rc, lh, future); + } + } + + static class SyncDeleteCallback implements AsyncCallback.DeleteCallback { + + private final CompletableFuture future; + + public SyncDeleteCallback(CompletableFuture future) { + this.future = future; + } + + + /** + * Delete callback implementation for synchronous delete call. + * + * @param rc + * return code + * @param ctx + * optional control object + */ + @Override + @SuppressWarnings("unchecked") + public void deleteComplete(int rc, Object ctx) { + SyncCallbackUtils.finish(rc, null, future); + } + } + + static class LastAddConfirmedCallback implements AsyncCallback.AddLacCallback { + static final LastAddConfirmedCallback INSTANCE = new LastAddConfirmedCallback(); + /** + * Implementation of callback interface for synchronous read method. + * + * @param rc + * return code + * @param lh + * ledger identifier + * @param ctx + * control object + */ + @Override + public void addLacComplete(int rc, LedgerHandle lh, Object ctx) { + if (rc != BKException.Code.OK) { + LOG.warn("LastAddConfirmedUpdate failed: {} ", BKException.getMessage(rc)); + } else { + if (LOG.isDebugEnabled()) { + LOG.debug("Callback LAC Updated for: {} ", lh.getId()); + } + } + } + } + + static class SyncReadCallback implements AsyncCallback.ReadCallback { + /** + * Implementation of callback interface for synchronous read method. + * + * @param rc + * return code + * @param lh + * ledger handle + * @param seq + * sequence of entries + * @param ctx + * control object + */ + @Override + @SuppressWarnings("unchecked") + public void readComplete(int rc, LedgerHandle lh, + Enumeration<LedgerEntry> seq, Object ctx) { + SyncCallbackUtils.finish(rc, seq, (CompletableFuture<Enumeration<LedgerEntry>>)ctx); + } + } + + static class FutureReadResult extends CompletableFuture<Iterable<org.apache.bookkeeper.client.api.LedgerEntry>> + implements AsyncCallback.ReadCallback { + + /** + * Implementation of callback interface for read method of {@link ReadHandle}. + * + * @param rc + * return code + * @param lh + * ledger handle + * @param seq + * sequence of entries + * @param ctx + * control object + */ + @Override + @SuppressWarnings("unchecked") + public void readComplete(int rc, LedgerHandle lh, + Enumeration<LedgerEntry> seq, Object ctx) { + if (rc != BKException.Code.OK) { + this.completeExceptionally(BKException.create(rc).fillInStackTrace()); + } else { + this.complete((Iterable) (() -> Iterators.forEnumeration(seq))); + } + } + } + + static class SyncAddCallback extends CompletableFuture<Long> implements AsyncCallback.AddCallback { + + /** + * Implementation of callback interface for synchronous read method. + * + * @param rc + * return code + * @param lh + * ledger handle + * @param entry + * entry identifier + * @param ctx + * control object + */ + @Override + @SuppressWarnings("unchecked") + public void addComplete(int rc, LedgerHandle lh, long entry, Object ctx) { + SyncCallbackUtils.finish(rc, entry, this); + } + } + + static class SyncReadLastConfirmedCallback implements AsyncCallback.ReadLastConfirmedCallback { + /** + * Implementation of callback interface for synchronous read last confirmed method. + */ + @Override + public void readLastConfirmedComplete(int rc, long lastConfirmed, Object ctx) { + LedgerHandle.LastConfirmedCtx lcCtx = (LedgerHandle.LastConfirmedCtx) ctx; + + synchronized(lcCtx) { + lcCtx.setRC(rc); + lcCtx.setLastConfirmed(lastConfirmed); + lcCtx.notify(); + } + } + } + + static class SyncCloseCallback implements AsyncCallback.CloseCallback { + + private final CompletableFuture future; Review comment: same comment as above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
