sijie commented on a change in pull request #889: BP-14 Implementation of
WriteFlag.DEFERRED_SYNC on Journal
URL: https://github.com/apache/bookkeeper/pull/889#discussion_r157885999
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
##########
@@ -1248,7 +1248,7 @@ private LedgerDescriptor getLedgerForEntry(ByteBuf
entry, final byte[] masterKey
bb.put(masterKey);
bb.flip();
- getJournal(ledgerId).logAddEntry(bb, new NopWriteCallback(),
null);
+ getJournal(ledgerId).logAddEntry(bb, false /* ackBeforeForce
*/, new NopWriteCallback(), null);
Review comment:
we stick to `deferred_sync`. I would suggest us using `ackBeforeSync` rather
than `ackBeforeForce`. we should make sure naming consistent across the places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
