sijie commented on a change in pull request #889: BP-14 Implementation of WriteFlag.DEFERRED_SYNC on Journal URL: https://github.com/apache/bookkeeper/pull/889#discussion_r157885411
########## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/DeferredSyncBookieTest.java ########## @@ -0,0 +1,89 @@ +/* + * Copyright 2017 The Apache Software Foundation. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.bookkeeper.client; + +import static org.apache.bookkeeper.client.api.WriteFlag.DEFERRED_SYNC; +import static org.apache.bookkeeper.common.concurrent.FutureUtils.result; +import static org.junit.Assert.assertTrue; + +import io.netty.buffer.ByteBuf; +import io.netty.buffer.Unpooled; +import java.util.Random; +import java.util.concurrent.CountDownLatch; +import java.util.concurrent.TimeUnit; +import org.apache.bookkeeper.bookie.Bookie; +import org.apache.bookkeeper.bookie.BookieShutdownTest; +import org.apache.bookkeeper.client.api.DigestType; +import org.apache.bookkeeper.client.api.WriteFlag; +import org.apache.bookkeeper.client.api.WriteHandle; +import org.apache.bookkeeper.net.BookieSocketAddress; +import org.apache.bookkeeper.proto.BookkeeperInternalCallbacks.WriteCallback; +import org.apache.bookkeeper.test.BookKeeperClusterTestCase; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Tests about bookie-side implementation of {@link WriteFlag#DEFERRED_SYNC} write flag. + */ +public class DeferredSyncBookieTest extends BookKeeperClusterTestCase { Review comment: if this class is only for testing bookie-side implementation, it should be in `bookie` package rather than `client` package. also you should just test bookie side changes, you don't need to involve client. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
