sijie commented on a change in pull request #889: BP-14 Implementation of
WriteFlag.DEFERRED_SYNC on Journal
URL: https://github.com/apache/bookkeeper/pull/889#discussion_r157887127
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
##########
@@ -283,30 +283,43 @@ public boolean accept(long journalId) {
WriteCallback cb;
Object ctx;
long enqueueTime;
+ boolean ackBeforeForce;
Review comment:
I would suggest defer adding these two variables until you really need them.
it isn't clear how callback will be executed and the object will be recycled in
some branches. this pull request should just take the flags and acknowledge
before sync.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
