sijie commented on a change in pull request #889: BP-14 Implementation of
WriteFlag.DEFERRED_SYNC on Journal
URL: https://github.com/apache/bookkeeper/pull/889#discussion_r161957305
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
##########
@@ -901,7 +921,7 @@ public void run() {
TimeUnit.NANOSECONDS);
}
- if (toFlush.isEmpty()) {
+ if (numEntriesToFlush == 0) {
Review comment:
I don't think we need to change this line here. It is better to use toFlush
here, because toFlush will never decrease on each run, while
`numEntriesToFlush` can be changed. it is good to use toFlush as the condition,
because all the group commit logic is based on toFlush.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
