sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata
service uri for constructing registration client
URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170567205
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
##########
@@ -215,6 +215,8 @@ public String getMetadataServiceUri() throws
ConfigurationException {
ledgerManagerType =
org.apache.bookkeeper.meta.FlatLedgerManagerFactory.NAME;
} else if (factoryClass ==
LongHierarchicalLedgerManagerFactory.class) {
ledgerManagerType =
LongHierarchicalLedgerManagerFactory.NAME;
+ } else if (factoryClass ==
org.apache.bookkeeper.meta.MSLedgerManagerFactory.class) {
Review comment:
don't think any more is using them. would like to deprecate the whole
interface after completing BP-29.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
