sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata
service uri for constructing registration client
URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170772420
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
##########
@@ -525,9 +532,9 @@ public BookKeeper(ClientConfiguration conf, ZooKeeper zk,
EventLoopGroup eventLo
// initialize ledger manager
try {
this.ledgerManagerFactory =
- AbstractZkLedgerManagerFactory.newLedgerManagerFactory(conf,
regClient.getLayoutManager());
- } catch (IOException | InterruptedException e) {
- throw e;
+ this.metadataDriver.getLedgerManagerFactory();
Review comment:
I am trying to reduce the amount code to change for places that references
`ledgerManagerFactory`. this should be done via a cleanup later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
