sijie commented on a change in pull request #1192: BP-29 (task 3): use metadata
service uri for constructing registration client
URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170774019
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataDrivers.java
##########
@@ -191,17 +202,28 @@ public static void registerClientDriver(String
metadataBackendScheme,
*/
public static void registerBookieDriver(String metadataBackendScheme,
Class<? extends
MetadataBookieDriver> driver) {
+ registerBookieDriver(metadataBackendScheme, driver, false);
+ }
+
+ @VisibleForTesting
+ public static void registerBookieDriver(String metadataBackendScheme,
+ Class<? extends
MetadataBookieDriver> driver,
+ boolean allowOverride) {
if (!initialized) {
initialize();
}
String scheme = metadataBackendScheme.toLowerCase();
MetadataBookieDriverInfo oldDriverInfo = bookieDrivers.get(scheme);
- if (null != oldDriverInfo) {
+ if (null != oldDriverInfo && !allowOverride) {
Review comment:
same as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
