ivankelly commented on a change in pull request #1192: BP-29 (task 3): use
metadata service uri for constructing registration client
URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170878297
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationClient.java
##########
@@ -327,9 +270,17 @@ public synchronized void
unwatchWritableBookies(RegistrationListener listener) {
@Override
public synchronized CompletableFuture<Void>
watchReadOnlyBookies(RegistrationListener listener) {
- CompletableFuture<Void> f = new CompletableFuture<>();
+ CompletableFuture<Void> f;
Review comment:
nit: add final to ensure all branches assign something. if returning a value
is something miss from scala.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
