ivankelly commented on a change in pull request #1192: BP-29 (task 3): use 
metadata service uri for constructing registration client
URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170913941
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
 ##########
 @@ -142,6 +145,9 @@
     // Features
     final Feature disableEnsembleChangeFeature;
 
+    final MetadataClientDriver metadataDriver;
+    // Registration client to discover bookies
+    final RegistrationClient regClient;
 
 Review comment:
   It's replacing it as far as BookKeeper is concerned. BookKeeper only has 
RegClient to manage the ownership of regClient. This is now handed off to 
MetadataClientDriver.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to