reddycharan commented on a change in pull request #1281: Issue #570:
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176881392
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java
##########
@@ -584,15 +584,6 @@ public void
testWithDiskFullReadOnlyDisabledOrForceGCAllowDisabled() throws Exce
} catch (NoWritableLedgerDirException e) {
// expected
}
-
Review comment:
in the existing implementation, when Bookie is initialized, it will
eventually call EntryLogger.initialize() -> EntryLogger.createNewLog() and it
would fail with exception because of
https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java#L184
. But now with this change we are not creating newlog during initialization of
Bookie ( and EntryLogger), EntryLog would be created only after receiving first
EntryLogger.addEntry call, hence Bookie initialization would succeed in this
case though IsForceGCAllowWhenNoSpace is set to false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
