reddycharan commented on a change in pull request #1281: Issue #570:
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177174411
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -513,78 +519,86 @@ void createNewLog() throws IOException {
EntryLoggerAllocator getEntryLoggerAllocator() {
return entryLoggerAllocator;
}
+
/**
* Append the ledger map at the end of the entry log.
* Updates the entry log file header with the offset and size of the map.
*/
- private void appendLedgersMap(BufferedLogChannel entryLogChannel) throws
IOException {
- long ledgerMapOffset = entryLogChannel.position();
-
- ConcurrentLongLongHashMap ledgersMap = entryLogChannel.getLedgersMap();
- int numberOfLedgers = (int) ledgersMap.size();
+ private void appendLedgersMap(Long ledgerId) throws IOException {
Review comment:
will move this appendLedgersMap method to BufferedLogChannel. Because of
that explicit need of converting from ledgerid to logchannel and
synchronization wont be required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
