sijie commented on a change in pull request #1319:  Issue 1316: A bookie with 
non-writable dirs should be able to start in readonly mode

 File path: 
 @@ -398,7 +401,11 @@ synchronized long getLeastUnflushedLogId() {
     synchronized long getCurrentLogId() {
-        return logChannel.getLogId();
+        return currentLogId;
+    }
+    BufferedLogChannel getCurrentLogChannel() {
 Review comment:
   Current EntryLogger assumes it is single entry log implementation. These 
methods are package-protected methods (not public method), they are exposed for 
testing purpose.
   If you are thinking from EntryLogManager perspective, these methods should 
be hidden to single entry log manager implementation. These methods should be 
only package-protected at single log manager implementation. 
   If you see inconvenient here, that means your EntryLogManager interface in 
#1281 is not defining the right interfaces. `currentLogId` and 
`currentLogChannel` should only matter and be testing on single log entry 
manager. you shouldn't never consider it for per ledger entry manager. If you 
think and define your EntryLogManager interface in this way, I don't think 
`currentLogId` and `currentLogChannel` is not a problem to you.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to