sijie commented on a change in pull request #1436: BP-14 force() API - client
side implementation
URL: https://github.com/apache/bookkeeper/pull/1436#discussion_r191294774
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java
##########
@@ -193,6 +194,30 @@ public PerChannelBookieClientPool
lookupClient(BookieSocketAddress addr) {
return clientPool;
}
+ public void forceLedger(final BookieSocketAddress addr, final long
ledgerId,
+ final ForceLedgerCallback cb, final Object ctx) {
+ final PerChannelBookieClientPool client = lookupClient(addr);
+ if (client == null) {
+
cb.forceLedgerComplete(getRc(BKException.Code.BookieHandleNotAvailableException),
+ ledgerId, addr, null);
Review comment:
`null` -> `ctx`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
