sijie commented on a change in pull request #1436: BP-14 force() API - client
side implementation
URL: https://github.com/apache/bookkeeper/pull/1436#discussion_r193181776
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -1822,6 +1892,17 @@ void handleBookieFailure(final Map<Integer,
BookieSocketAddress> failedBookies)
return;
}
+ if (writeFlags.contains(WriteFlag.DEFERRED_SYNC)) {
+ blockAddCompletions.decrementAndGet();
+ if (LOG.isDebugEnabled()) {
Review comment:
The comment isn't aligned with the function call. Are you retrying or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
