sijie commented on a change in pull request #1436: BP-14 force() API - client
side implementation
URL: https://github.com/apache/bookkeeper/pull/1436#discussion_r193178082
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DistributionSchedule.java
##########
@@ -149,6 +149,13 @@ public WriteSet copy() {
*/
WriteSet getWriteSetForLongPoll(long entryId);
+ /**
+ * Return the set of bookies indices to send the messages to for force
ledger.
+ *
+ * @return the set of bookies indices to send force request to.
+ */
+ WriteSet getWriteSetForForceLedger();
Review comment:
This will become unmanageable. We ended up adding getWriteSetFor for
different type of requests. I would suggest: renaming `getWriteSetForLongPoll`
to `getEnsembleWriteSet`, because those requests are required to send to the
whole ensemble.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
