coolbeevip commented on a change in pull request #2347:
URL: https://github.com/apache/bookkeeper/pull/2347#discussion_r429690282
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java
##########
@@ -125,6 +135,8 @@ private static ServerConfiguration parseArgs(String[] args)
ServerConfiguration conf = new ServerConfiguration();
+ loadConfEnv(conf);
+
if (cmdLine.hasOption('c')) {
String confFile = cmdLine.getOptionValue("c");
loadConfFile(conf, confFile);
Review comment:
Thank you for reminding me, my intention is that the environment
variable has a higher priority than the configuration file.
I will modify it to call LoadConfEnv after loadConfFile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
